Re: wine/dlls/shell32 shell32_main.c

[BiGgUn]

Hi,
> | @@ -297,6 +299,9 @@
> |    return 0;
> |        }
> |
> | +      /* psfi is NULL normally to query EXE type, if not none of the
> below makes
> | +           sense anyway. Windows allows this and just returns FALSE
> */
> | +      if (psfi != NULL) return FALSE;
>
> this is obviously wrong (psfi is dereferenced in the remainder of the
> function). I just wonder if it should be removed, or is here a typo and
> should != be  == ?

I think this instruction should be removed because it has no sense.  When
you query EXE type, this instruction is never reached. A value is always
returned , psfi == NULL or not. In other cases ( file dialog icons for
instance) , this instruction makes things going wrong.

Stephan