16 Nov
2021
16 Nov
'21
6:43 p.m.
On 11/16/21 17:51, Jinoh Kang wrote:
Replace the series of sscanf in packet_query with a dedicated qXfer request parser function and a lookup into a predefined handler table.
Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- programs/winedbg/gdbproxy.c | 218 ++++++++++++++++++++++++++---------- 1 file changed, 160 insertions(+), 58 deletions(-)
To be honest I find the sscanf version much more readable, especially as gdb protocol is not always easy to follow, and the number of possible qxfer variants (3) doesn't really justify to use a dispatch table imho. Is this change solving anything in particular? -- Rémi Bernon <rbernon(a)codeweavers.com>