Re: shellpath.c: Avoid copying invalid data on error

[Juan Lang]

--- Alexandre Julliard <julliard(a)winehq.org> wrote:
> > - it doesn't add a break statement to the default
> > case (some compilers warn on this)
>
> I seriously doubt that, what compiler does this for
> you?

MSVC at certain warning levels IIRC.  But my memory is
suspect.
> > -    WCHAR      szBuildPath[MAX_PATH],
> > szTemp[MAX_PATH];
> > +    WCHAR      szBuildPath[MAX_PATH],
> > szTemp[MAX_PATH] = { 0 };
>
> This fills the whole buffer with zeroes, that's not
> really needed.

Agreed, I prefer = "", but this is a WSTR so I can't
do that.

--Juan


		
__________________________________
Do you Yahoo!?
Yahoo! Mail Address AutoComplete - You start. We finish.
http://promotions.yahoo.com/new_mail