Re: [PATCH v2 2/6] dxgi: Signal frame latency event on present.

[Henri Verbeet]

On Thu, 16 Apr 2020 at 01:47, Philip Rebohle
<philip.rebohle(a)tu-dortmund.de> wrote:
> +    if (swapchain->desc.Flags & DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT)
> +    {
> +        ++swapchain->frame_number;
> +
> +        if (FAILED(hr = ID3D12CommandQueue_Signal(swapchain->command_queue,
> +                swapchain->frame_latency_fence, swapchain->frame_number)))
> +        {
> +            ERR("Failed to signal frame latency fence, hr %#x.\n", hr);
> +            return hr;
> +        }
> +
> +        if (FAILED(hr = ID3D12Fence_SetEventOnCompletion(swapchain->frame_latency_fence,
> +                swapchain->frame_number - swapchain->frame_latency, swapchain->frame_latency_event)))
> +        {
> +            FIXME("Failed to enqueue frame latency event, hr %#x.\n", hr);
> FIXME doesn't seem appropriate here. If we take the position that this
> should never fail, this should be an ERR like the one for the
> ID3D12CommandQueue_Signal() call above. FIXME would be for
> missing/incomplete/broken functionality.