Re: [PATCH] cabinet: Properly initialize our internal fci structure v2(bug 36115)(valgrind)

[Huw Davies]

On 14 Nov 2016, at 16:46, Detlef Riekenberg <wine.dev(a)web.de> wrote:
> We did not initialize all items for our internal fci structure.
> This should fix bug 36115
>
> v2:
> Remove comments, as suggested by Huw
>
> --
> bye bye ... Detlef
>
> Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de>
> ---
> dlls/cabinet/fci.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c
> index 70d4f3f..03fbf46 100644
> --- a/dlls/cabinet/fci.c
> +++ b/dlls/cabinet/fci.c
> @@ -1036,6 +1036,7 @@ HFCI __cdecl FCICreate(
>     return NULL;
>   }
>
> +  memset(p_fci_internal, 0, sizeof(FCI_Int));

I also suggested changing the sizeof(FCI_Int) -> sizeof(*p_fci_internal),
but maybe that wasn’t very clear.

Huw.