Re: [1/6] shdocvw: Add menu bar to Internet Explorer

[Jacek Caban]

Hi Alexander,

On 7/21/10 2:07 PM, Alexander Nicolaysen Sørnes wrote:
> This series adds a menu bar and Open URL dialog box to Wine's IE.

-    FIXME("(%p)->(%x)\n", This, Value);
-    return E_NOTIMPL;
+    HMENU hMenu = NULL;

Please use better names (without type prefix) like 'menu'.

+
+    TRACE("(%p)->(%x)\n", This, Value);
+
+    if(Value == VARIANT_TRUE)

You shouldn't compare Value directly to VARIANT_TRUE.

+        hMenu = LoadMenuW(shdocvw_hinstance, MAKEINTRESOURCEW(IDR_BROWSE_MAIN_MENU));
+
+    if(!SetMenu(This->frame_hwnd, hMenu))
+        return HRESULT_FROM_WIN32(GetLastError());
+

+
+    return S_OK;

You leak hMenu here.


Jacek