Re: [PATCH 2/2] kernel32: Stub FindFirstStreamW/FindNextStreamW

[Nikolay Sivov]

On 3/30/19 10:40 PM, Fabian Maurer wrote:
> +/**************************************************************************
> + *           FindFirstStreamW   (KERNEL32.@)
> + */
> +HANDLE WINAPI FindFirstStreamW(LPCWSTR lpFileName, STREAM_INFO_LEVELS infoLevel,
> +    LPVOID lpFindStreamData, DWORD dwFlags)
> +{
> +    FIXME("(%s, %d, %p, %x): stub!\n", debugstr_w(lpFileName), infoLevel, lpFindStreamData, dwFlags);
> +
> +    SetLastError(ERROR_HANDLE_EOF);
> +    return INVALID_HANDLE_VALUE;
> +}
> +
> +
> +/**************************************************************************
> + *           FindNextStreamW   (KERNEL32.@)
> + */
> +BOOL WINAPI FindNextStreamW(HANDLE hFindStream, LPVOID lpFindStreamData)
> +{
> +    FIXME("(%p, %p): stub!\n", hFindStream, lpFindStreamData);
> +
> +    SetLastError(ERROR_HANDLE_EOF);
> +    return FALSE;
> +}

Please use better argument and type names.

Regarding error code, will it work if you set it to NOT_IMPLEMENTED?
> @@ -488,7 +488,7 @@
>   # @ stub FindFirstFileTransactedW
>   @ stdcall FindFirstFileW(wstr ptr)
>   # @ stub FindFirstStreamTransactedW
> -# @ stub FindFirstStreamW
> +@ stub FindFirstStreamW(str long ptr long)
>   @ stdcall FindFirstVolumeA(ptr long)
>   @ stdcall FindFirstVolumeMountPointA(str ptr long)
> Why 'stub'? Is it enough to have 'stub' entry for application to work? 
> Also first argument type is wrong.