Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().

[Henri Verbeet]

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> ---
>  dlls/wined3d/utils.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c
> index da8fc7b..5010676 100644
> --- a/dlls/wined3d/utils.c
> +++ b/dlls/wined3d/utils.c
> @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct wined3d_gl_info *gl_info, struct wined
>      GLenum status;
>      GLuint tex;
>
> +    if (!(format->flags & WINED3DFMT_FLAG_TEXTURE))
> +        return;
> +

I'm not sure about this one, what exactly should this achieve? In
either case, this probably belongs in init_format_fbo_compat_info(),
together with the other similar checks.