Re: [PATCH 2/5] ntdll: Reorder code to make the select logic clearer.

[Jacek Caban]

Hi Rémi,

On 04.02.2020 11:09, Rémi Bernon wrote:
> @@ -634,9 +638,8 @@ unsigned int server_select( const select_op_t *select_op, data_size_t size, UINT
>               size = 0;
>           }
>
> -        /* don't signal multiple times */
> -        if (size >= sizeof(select_op->signal_and_wait) && select_op->op == SELECT_SIGNAL_AND_WAIT)
> -            size = offsetof( select_op_t, signal_and_wait.signal );
> +        if (ret == STATUS_PENDING) ret = wait_select_reply( &cookie );
> +        if (ret != STATUS_USER_APC && ret != STATUS_KERNEL_APC) break;
>       }

After your reordering, it's essentially do {} while() loop, maybe you 
could use that.


Thanks,

Jacek