Re: [PATCH 7/8] winedump: Use common binary dumper for typelib.

[Dmitry Timoshkov]

Jacek Caban <jacek(a)codeweavers.com> wrote:
> > -static void dump_binary(int n)
> > +static int tlb_isprint(unsigned char c)
> >  {
> > -    int i;
> > +    return c >= 32;
>
> It seems to me that adding something like c <= 128 would make the output
> better. At lest it looks better in my testing.

dump.c uses plain isprint() but this completely misses for instance cyrillic
cp 1251 characters I had to test the dumper (and the SLTG generator) with.
This was especially important for figuring out the algorithm used for the SLTG
compressed help strings.

-- 
Dmitry.