Re: Tab control TCM_SETITEMEXTRA (bugzilla #1046)

[Alexandre Julliard]

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes:
> @@ -2557,8 +2562,10 @@
>      infoPtr->items[iItem].iImage = pti->iImage;
>
> if (pti->mask & TCIF_PARAM)
> -    infoPtr->items[iItem].lParam = pti->lParam;
> -
> +    memcpy(&infoPtr->items[iItem].lParam, &pti->lParam, infoPtr->cbInfo);
> +  else
> +    memset(&infoPtr->items[iItem].lParam, 0, infoPtr->cbInfo);

That doesn't look right at all, lParam is not at the end of the
structure. And the variable-size info should really be a byte array or
something similar, not an LPARAM.

-- 
Alexandre Julliard
julliard(a)winehq.org