9 Jul
2010
9 Jul
'10
8:04 p.m.
On 09/07/10 14:22, Dan Kegel wrote:
Thanks for sending that patch.
It seems your editor stripped whitespace from the ends of lines, causing three whitespace-only hunks on the end of your patch. Please don't do that; Wine deveopers frown on unrelated whitespace changes.
You might have better luck getting your change in if you include a test.
Now I see that revised patch 63334 is in "Needs Tests" state, I'm not a windows application developer... I am not able to write any new test for this. There are already 52 uses of EndDialog in dlls/user32/tests If these still pass...? OrCad works with my changes. LTSpice and PADS work as well as they did before. this is as far as I can go with it. regards Eliot