Re: [PATCH v4 2/2] ntdll: Prevent loading Wine system dependencies in place of identically named application DLLs.

[Alexandre Julliard]

Zebediah Figura <zfigura(a)codeweavers.com> writes:
> @@ -903,6 +907,7 @@ void * WINAPI RtlFindExportedRoutineByName( HMODULE module, const char *name )
>   */
>  static BOOL import_dll( HMODULE module, const IMAGE_IMPORT_DESCRIPTOR *descr, LPCWSTR load_path, WINE_MODREF **pwm )
>  {
> +    BOOL system = current_modref->system || (current_modref->ldr.Flags & LDR_WINE_INTERNAL);

This means that all builtins will be marked system, and won't be found
in searches by basename. That doesn't seem right.

The extra loader magic that you add should be a complete no-op when
system dlls are not in use.

-- 
Alexandre Julliard
julliard(a)winehq.org