Re: [PATCH resend] comctl32: When adding a scrollbar to a listview, update the other one.

[Alistair Leslie-Hughes]

Hi Alex,

On 03/05/17 14:53, Alex Henrie wrote:
> Cc: Nikolay Sivov <nsivov(a)codeweavers.com>
> +static void LISTVIEW_UpdateScroll(LISTVIEW_INFO *infoPtr)
> +{
> +    INT dx, dy;
> +
> +    if ((infoPtr->dwStyle & LVS_NOSCROLL) || !is_redrawing(infoPtr)) return;
> +
> +    /* Setting the horizontal scroll can change the listview size
> +     * (and potentially everything else) so we need to recompute
> +     * everything again for the vertical scroll and vice-versa
> +     */
> +
> +    dx = LISTVIEW_UpdateHScroll(infoPtr);
> +    dy = LISTVIEW_UpdateVScroll(infoPtr);
> +    dx += LISTVIEW_UpdateHScroll(infoPtr);
> +    dy += LISTVIEW_UpdateVScroll(infoPtr);
> +
> Is there any reason your calling update twice for each control?

Best Regards
 Alistair Leslie-Hughes