Re: [PATCH] [Server]: fix access rights for console creation (#24792)

[Alexandre Julliard]

Eric Pouech <eric.pouech(a)orange.fr> writes:
> +    if (access & GENERIC_READ)    access |= FILE_GENERIC_READ;
> +    /* FIXME: we add FILE_READ_PROPERTIES access even in write-only mode.
> +     * As tested on Windows, this is not correct (ie GetConsoleMode() on with GENERIC_WRITE only
> +     * access fails).
> +     * But, this is currently needed as part of kernel32/console.c client side code relies on the
> +     * fact that it can read properties: lots of 'set' functions like WriteConsole,
> +     * ScrollConsoleScreenBuffer, SetConsoleCursorPosition (and many others) do call 'get'
> +     * functions.
> +     */

These should be fixed then.

-- 
Alexandre Julliard
julliard(a)winehq.org