Mike Hearn <mike(a)theoretic.com> writes:
Index: dlls/shell32/pidl.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/pidl.c,v retrieving revision 1.94 diff -u -r1.94 pidl.c --- dlls/shell32/pidl.c 4 Nov 2003 04:21:01 -0000 1.94 +++ dlls/shell32/pidl.c 25 Dec 2003 19:32:48 -0000 @@ -1234,10 +1234,19 @@ LPSHELLFOLDER shellfolder;
TRACE_(shell)("(pidl=%p,%p)\n",pidl,pszPath); - pdump(pidl);
- if (!pidl) return FALSE; + if (!pidl) { + ERR_(shell)("argument check failed: pidl == null\n"); + return FALSE; + } + + if (!pszPath) { + ERR_(shell)("argument check failed: pszPath == null\n"); + return FALSE; + }
The ERRs are useless. If Windows does a NULL check, then we should do one too, without any error message; if Windows doesn't, then we shouldn't check at all. -- Alexandre Julliard julliard(a)winehq.com