Re: [PATCH (resend) 1/2] dpvoice/tests: Add GetCompressionTypes tests.

[Alexandre Julliard]

Alex Henrie <alexhenrie24(a)gmail.com> writes:
> @@ -343,6 +343,179 @@ static void create_voicetest(void)
>      }
>  }
>
> +static void test_GetCompressionTypes(HRESULT (__stdcall *GetCompressionTypes)(void*,void*,DWORD*,DWORD*,DWORD),
> +                                     void *iface, const char *name)

These hacks with the void pointers are ugly. You should pass interface
pointers and do a proper method call with one or the other, for instance
something like this:

  if (client_iface)
      IDirectPlayVoiceClient_GetCompressionTypes( client_iface,... );
  else
      IDirectPlayVoiceServer_GetCompressionTypes( server_iface,... );


-- 
Alexandre Julliard
julliard(a)winehq.org