Re: [PATCH 5/6] d3d9: Retrieve texture states from the primary stateblock.

[Henri Verbeet]

On Wed, 12 Feb 2020 at 04:55, Zebediah Figura <z.figura12(a)gmail.com> wrote:
> static HRESULT WINAPI d3d9_device_GetTextureStageState(IDirect3DDevice9Ex *iface,
> -        DWORD stage, D3DTEXTURESTAGESTATETYPE state, DWORD *value)
> +        DWORD sampler_idx, D3DTEXTURESTAGESTATETYPE state, DWORD *value)

The change of "stage" to "sampler_idx" may be defensible for
GetTexture(), although it's still a little ugly to use different
terminology for GetTexture() and SetTexture(). I think it's more
questionable here; texture stage states are only incidentally related
to samplers. Depending on the specific state set, a particular stage
may not reference any texture or sampler at all.