Re: [PATCH] dlls: Global variable compatibility update for gcc 10

[Alistair Leslie-Hughes]

Hi Michael,

You will need to split this patch up into smaller patches, 1 per dll 
would be enough.

On 23/1/20 2:18 pm, Michael Cronenworth wrote:
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fgcc-10%2Fporting_to.html%23common&data=02%7C01%7C%7Cafc232638e724519537d08d79fb31147%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637153463750593223&sdata=cYdXVA9fGmBnR6BOqZ7t%2BVMslT9pkTFdo6s8Fn1Ultk%3D&reserved=0
>
> Default to -fno-common
> -} activeDS DECLSPEC_HIDDEN;
> +} extern activeDS DECLSPEC_HIDDEN;

This doesn't look right,  maybe explicitly adding to the header would 
look better.
extern struct activeDS DECLSPEC_HIDDEN

This goes for other places as well.

Regards
Alistair.