9 Jun
2022
9 Jun
'22
2:37 p.m.
Huw Davies (@huw) commented about dlls/uiautomationcore/uia_provider.c:
+ matched = TRUE; + goto exit; + } + else + { + IUnknown *unk, *unk2; + + IAccessible_QueryInterface(acc, &IID_IUnknown, (void**)&unk); + IUnknown_Release(unk); + IAccessible_QueryInterface(acc2, &IID_IUnknown, (void**)&unk2); + IUnknown_Release(unk2); + if (unk == unk2) + { + matched = TRUE; + goto exit; + } Releasing the ifaces before comparing them looks odd. This is also done in the tests of the third patch.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/216#note_1754