10 Aug
2008
10 Aug
'08
7:16 a.m.
Hi Scott, I didn't see a reply to your AcceptEx patches yet, sorry if I missed it and you get this again. Please submit one patch per email only. I admittedly don't know much about the wineserver stuff, but I've noticed a couple of style issues in the winsock code: The indentation common in socket.c is either a two-space indent or a four-space indent. Please don't add new code with an eight-space indent. Also, the common convention for ifs is if (cond) { and not if(cond){ Apart from those minor nitpicks, the code looks good. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.