Re: [PATCH v2] vbscript: Support properties with parameters.

[Robert Wilhelm]

Hi Jacek,

thank you for the review.
I assumed there is only one Named Arg.
I will send updated patch shortly.

Regards,
Robert

On Fri, 2020-11-13 at 22:22 +0100, Jacek Caban wrote:
> Hi Robert,
>
> On 11/12/20 7:52 AM, Robert Wilhelm wrote:
> > +            for( i=1,j=0; i<dp.cArgs;i++,j++) {
> > +                if (j==index) {
> > +                    j++;
> > +                }
> > +                dp.rgvarg[i]=params->rgvarg[j];
> > +            }
>
> This is inconsistent with how you allocate dp, where you use
> arg_cnt().
> I think that allocation is right and we should skip first cNamedArgs
> entries of rgvargs and copy the rest here. You could then avoid
> returning index from get_propput_arg.
>
> Thanks,
> Jacek