16 Jul
2010
16 Jul
'10
2:55 p.m.
On 07/16/2010 03:50 PM, Dan Kegel wrote:
So it boils down to disagreements about two things:
- mentioning a bug number when posting a patch I think this is a misunderstanding. There are different ways of adding the bug number when posting a patch:
Very BAD: --------- Changelog: This fixes bug #4711 BAD: ---- Changelog: Change the handling of flags X Y Z because this fixes bug #4711 OK: --- Changelog: Change a corner case in the handling of flags X Y Z (with tests). This resolve the issue from bug #4711. The bug number is *only* additional information. It isn't the justification for a patch and definitely not the sole changelog. bye michael