Re: [hhctrl.ocx] Null pointer fix, new patch

[Andrew Nguyen]

On Tue, Jun 22, 2010 at 6:13 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> On 6/22/2010 15:09, Andrew Nguyen wrote:
> > On Tue, Jun 22, 2010 at 5:56 AM, Jaroslav Šmíd<jardasmid(a)gmail.com>
> >  wrote:
> > > -        info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle);
> > > +        info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ?
> > > info->pCHMInfo->defTitle : null);
> >
> > Perhaps I am missing something obvious, but isn't the new statement
> > practically the same as the one you removed? Adding a conditional
> > doesn't seem to change what strdupW receives, and thus what it
> > ultimately returns.
>
>  static const WCHAR null[] = {0};

You're perfectly correct, and I should have known better. I should
perhaps get some rest.