Re: user32: Implement GetWindowModuleFileName with tests

[Reece Dunn]

On 08/02/2008, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
> "Reece Dunn" <msclrhd(a)googlemail.com> wrote:
> > > What's the point of saving/restoring last error value? If WideCharToMultiByte
> > > fails you need to return an error in that case, not silently continue.
> >
> > The usual model is something like this:
> >
> > SetLastError(0xdeadbeef);
> >    WinApiCall();
> >    ok(GetLastError() == ERROR_SUCCESS, "WinApiCall failed, expected
> > ERROR_SUCCESS, got %d", GetLastError());
>
> In the tests, which is not the case here.

Sorry, yes. You are correct.

- Reece