Re: [PATCH v2 2/2] msxml3: Don't unlink the XML declaration when saving document.

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

Please don't commit this, while the patch is correct, it causes a regression:
::load()/::save() leads to a bug: the saved file has double <?xml> header,
and needs another fix: doparse() should never add an xml declaration to a just
loaded XML.

Nikolay, do you recall why that code was added in the first place?

I'll add more tests for such a case.

-- 
Dmitry.