24 Mar
2004
24 Mar
'04
6:29 p.m.
"C. Daniel Mojoli B." <cdmojoli(a)idea.com.py> writes:
I agree with the principle, but still advocate the inclusion of the magic number patch because it allows to fail-fast. Even when someone eventually patches for complete validity and bounds checking, the fail-fast magic number test remains useful.
I don't think failing fast is important at all; on the contrary, the normal case is that the icon file is valid, and making that case slower to make the rare case faster is not a good trade-off. -- Alexandre Julliard julliard(a)winehq.org