Re: (resend 2)[1/5]hidclass.sys: Implement helper IoCallMinidriver

[Henri Verbeet]

On 10 July 2015 at 21:39, Aric Stewart <aric(a)codeweavers.com> wrote:
> +NTSTATUS IoCallMinidriver(ULONG code, DEVICE_OBJECT *device, VOID *in_buff, ULONG in_size, VOID *out_buff, ULONG out_size) DECLSPEC_HIDDEN;
> This is unused until patch 3/5. It also seems like a really bad idea
> to name internal helper functions like Windows functions.
> +    if (out_size)
> +    {
> +        buffer = HeapAlloc(GetProcessHeap(), 0, out_size);
> +        memcpy(buffer, out_buff, out_size);
> +    }
> Either out_buff and out_size are really badly named, or this is really
> suspicious.