Re: [PATCH 2/3] d3dx10: Handle format converting for D3DX10CreateTextureFromMemory.

[Matteo Bruni]

On Thu, Jun 24, 2021 at 5:45 AM Ziqing Hui <zhui(a)codeweavers.com> wrote:
> > This patch made me look back to this hunk from D3DX10GetImageInfoFromMemory():
> >
> > if (img_info->ImageFileFormat == D3DX10_IFF_DDS)
> > {
> >     ...
> > }
> > else
> > {
> >     ...
> >     img_info->Format = DXGI_FORMAT_R8G8B8A8_UNORM;
> >     ...
> > }
> >
> > That seems suspicious, can't formats other than DDS (e.g. WMP) support
> > higher bit depths with d3dx10?
> > Maybe I can send a patch that adds more test images (e.g. WMP images which have higher bit depths) after this patch set is finished ?

Yes, sure, you don't have to test (and maybe fix) it right away.