On 26.02.19 23:19, Timothy Pearson wrote:
From: "André Hentschel" <nerv(a)dawncrow.de> To: "Timothy Pearson" <tpearson(a)raptorengineering.com>, "wine-devel" <wine-devel(a)winehq.org> Sent: Tuesday, February 26, 2019 12:48:33 PM Subject: Re: [PATCH 2/3] Initial port to PowerPC 64 Little Endian systems Verified
Hi,
Some notes on this patch: * Please split it, see my ARM or even better my ARM64 patches for it: [1], especially [2] (6 years ago, WHAT???) * git complains about white-space issues when applying, those need to be fixed * I needed to add support in the wine tools for powerpc64le, because my toolchain was named that way * I had a quick try with qemu user space emulation and directly ran into the assertion in signal_ppc64.c:signal_alloc_thread(): assert( sizeof(TEB) <= min_size ); * A very minor one: For easier searching for commits a constant platform naming helps, I tried to include "ARM64" in all related patch subjects, maybe PPC64 fits here well
Thanks for the feedback and links. I'll start working on a v2.
What did you need to edit for powerpc64le? I can throw that in as another patch in the series.
Duplicating the detection line like this should be enough: { "powerpc64", CPU_POWERPC64 }, { "powerpc64le", CPU_POWERPC64 },