I will add traces in next version. This dead code is used in another patch which is not yet sent, for classfactory implementation. I will remove this in next version. On Wed, Apr 3, 2019 at 8:57 PM Zebediah Figura <z.figura12(a)gmail.com> wrote:
On 04/03/2019 12:15 PM, Vijay Kiran Kamuju wrote:
+static HRESULT WINAPI manager_CreateAnimationVariable( IUIAnimationManager *iface, DOUBLE initial_value, IUIAnimationVariable **variable ) +{ + struct manager *This = impl_from_IUIAnimationManager( iface ); + FIXME( "stub (%p)->( )\n", This ); + return E_NOTIMPL; +}
Is there a reason you're not tracing parameter values?
+HRESULT manager_create( IUnknown *outer, REFIID iid, void **obj ) +{ + struct manager *This = heap_alloc( sizeof(*This) ); + HRESULT hr; + + if (!This) return E_OUTOFMEMORY; + This->IUIAnimationManager_iface.lpVtbl = &manager_vtbl; + This->ref = 1; + + hr = IUIAnimationManager_QueryInterface( &This->IUIAnimationManager_iface, iid, obj ); + + IUIAnimationManager_Release( &This->IUIAnimationManager_iface ); + return hr; +} +
This isn't used anywhere, so you're effectively introducing a bunch of dead code.
Tests would also be nice.