Re: [PATCH v5 1/6] wmp: Implement playback via quartz

[Jacek Caban]

On 03/28/2018 04:59 PM, Anton Romanov wrote:
> On Wed, Mar 28, 2018 at 7:39 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> > Hi Anton,
> >
> > On 03/28/2018 06:00 AM, Anton Romanov wrote:
> > > +    if (!This->filter_graph) {
> > > +        return NS_S_WMPCORE_COMMAND_NOT_AVAILABLE;
> > > +    }
> > > +    if (This->media_control) {
> > > +        hres = IMediaControl_Stop(This->media_control);
> > > +        IMediaControl_Release(This->media_control);
> > > +    }
> > > +    if (!This->filter_graph) {
> > > This doesn't look right, did you mean if (This->filter_graph)? Note that
> > > Yes, I did mean that, its a typo :(  (or rather a copy-paste error)

Yeah, but still, do you need that check? Note that you return earlier if
it's NULL. Do you expect that it may change inside IMediaControl_Stop call?

Jacek