Re: [PATCH v2] ddraw/tests: add test for HWTRANSFORMANDLIGHT flags

[Henri Verbeet]

Hi Vijay,

On Sat, 30 Mar 2019 at 01:28, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> @@ -399,6 +413,10 @@ static IDirect3DDevice7 *create_device(HWND window, DWORD coop_level)
>      ok(SUCCEEDED(hr), "Failed to enumerate devices, hr %#x.\n", hr);
>      if (hal_ok) devtype = &IID_IDirect3DTnLHalDevice;
>
> +    hr = IDirect3D7_EnumDevices(d3d7, enum_devtype_software_cb , &software_ok);
> +    ok(SUCCEEDED(hr), "Failed to enumerate devices, hr %#x.\n", hr);
> +    if (!software_ok) win_skip("RGB device not found, unable to check flags\n");
> +
> I  don't think it's useful to test this for each create_device() call.
> Also, how about the other ddraw versions and different device types
> like e.g. Ramp and MMX devices?