Re: [PATCH v2 2/2] odbccp32: Implement SQLWriteDSNToIni/W

[Alexandre Julliard]

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes:
> +    /* It doesn't matter if we cannot find the driver, windows just writes a blank value. */
> +    if ((ret = RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey)) == ERROR_SUCCESS)
> +    {
> +        HKEY hkeydriver;
> +
> +        if ((ret = RegOpenKeyW(hkey, lpszDriver, &hkeydriver)) == ERROR_SUCCESS)
> +        {
> +            ret = RegGetValueW(hkeydriver, NULL, L"driver", RRF_RT_REG_SZ, &type, NULL, &size);
> +            if(ret != ERROR_SUCCESS || type != REG_SZ)
> +            {
> +                RegCloseKey(hkey);
> +            }

Did you mean to return an error here?

-- 
Alexandre Julliard
julliard(a)winehq.org