-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, There are two more style issues I missed in my previous reviews:
+ static const struct + { + DWORD color1, color2; + DWORD rgb1, rgb2; + } + test_data[] = + { + { 0x000000, 0xffffff, 0x00008800, 0x00ff7dff }, + { 0xff0000, 0x00ffff, 0x004aff14, 0x00b800ee }, + { 0x00ff00, 0xff00ff, 0x000024ee, 0x00ffe114 }, + { 0x0000ff, 0xffff00, 0x00b80000, 0x004affff }, + { 0xffff00, 0x0000ff, 0x004affff, 0x00b80000 }, + { 0xff00ff, 0x00ff00, 0x00ffe114, 0x000024ee }, + { 0x00ffff, 0xff0000, 0x00b800ee, 0x004aff14 }, + { 0xffffff, 0x000000, 0x00ff7dff, 0x00008800 }, 4 space indents in the data block.
+ DWORD color = (x < width/2 && y < height/2) ? test_data[i].color1 : test_data[i].color2; Please use spaces consistently around binary opertions. (i.e. x < width / 2) etc. I think I've also seen some multiplications that are affected.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/MXbAAoJEN0/YqbEcdMwJjQP/2OzFt2DE5iEhWuwTOACdXSM 1dhlZnmz4bH+sUymen1dvxIXCLxhKWlLGl5cPkkFk2OCj0B2YlYaheV4qDJj5Cye zfKyrKjv1nfwk86g5YepoS2Ee/ZUdiMkNF+5tq9FkAa5LjStTgpC4KU6Vxpye1i5 Wmv2IBc0jAe84pRoDuZGYt0CT/RqgdHo8yvouK6Z5ytS7ClpLYWrLt/FYhpk0Sjj ITa6l7NksgBVN4ByZW5Pyk9Hf8gZ44qx9J8rzxOGBxLkGGpTOuGLB9MsE4riYwGy M1X10s7llWCs7Qy8Hs96Gg4vfHMS09xgfuYlj3UBKaXJVyRhTIDJpc7iqXA4WDaN mWJUrVaHCPha6ZGW2llC43wh5zECMH1/v98veRICbYqFhlKFzWuhtLq4BOwloJj4 fvJaYivFhkyDsn1y5grO8dGYjirZFNkiG/dIj7XpO8lh+4xGuTrBCO5hWBqICLV2 uQX6woh2MKv7ddFmRdvUuL/emV8oKBKga9t8LgTQdeSX7v//5aPtCLeawPKczpIB yPv2zUIei3G5TAcLlter66KGyvQZgXhiZXwtwq0wCWvNWRitjTztLp+2jrg9uWJ1 JiuhXuBFbsI8r/iiTrYXmZv1vX6BBFfL8I59SS0+J/7dFFZ63F5ePqEsl0WKSQ0W 0haQuTaKNLiVBlP1pmkF =fSNX -----END PGP SIGNATURE-----