-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-03 20:39, schrieb Francois Gouget:
But independently from that I think it's wrong because one should be able to compile the conformance tests on Windows. The purpose of this patch was to be able to compile the tests in msvc. But there may be some quirks in the build setup, see below.
So one solution would be to revert the patch. Another would be to copy wine/port.h's __port_nan() definition. Yet another might be to add xmath.h and a dependency on msvcrt.dll. But maybe there's a better way still? NAN was available, and I assumed that I got the one from port.h. Admittedly I didn't check where exactly it came from. Maybe msvc 2013 added a NAN definition.
My msvc build setup is a bit quirky. I wanted to avoid needing a full mingw setup, so I ended up (over time, adding one detail after another) cloning a part of the Wine build system as a msvc project. I'll boot Windows and see where the NAN comes from exactly. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSxyh6AAoJEN0/YqbEcdMw1IoP/1XIKj13LgyQTLznU3wzwgNx s3lt2S02Y1Im35dWig6ekCIIB4AriFIZ/mMPCXCxwbadklxXe7w/Y8bjDG+o+lCy rtIRnveotgtSSF8G6MMtIByDWhro1EeYRv93YXpjIZsIJTg50GWUxf61RLh6YFII 5Y4VRS8pBg3+UgVHGgutHqrbuGIuJo0Dk7eVpMjwOSMkseH/egvjqWVuJRe/aTAm cMkIGi78i9XwICKiMoXODin6Ipv3KMxul0uNTHJYcc7QqUdRt/US8ME5B2UJr6ek BjkGthNrOEvQl+EjBz5HaX5pLuUUWGDH/PfVwiPMm9jC0oCDVGuTnCweA964cSZE msdImJOJ1rrOIFT+Xk4YZkIjMf/Mr7TYKNCUoBJVNb4SP+pJNvyfBgWx/s9bGMo4 7DZvIRGXCrZqmvK0e0Q3JyPohW4jMYIOei6yxBK5OtctnxO7MmuOQIYC/XVxGbJH E/KjqbLsk/xwYavXNbirn1kS97neyEgguPZCXg1/lVCPHlmRu+96BmHlf5RvwzUb BGvSjm0WsmBcsDj/Fa5D8Q6n586oeek9q2KTGGwq5wPxLtznq/eArR/U0u9JACGR +7fxFRkjdHJvtKaLohw4B/AOTijRiDwg1iMxGecpqye5Grg7JAKsjcA3EcTxsX3S /ssXcB1sNA2wuAT6CJwU =ScXv -----END PGP SIGNATURE-----