Re: [PATCH v8 1/3] jscript: Lookup and ref the named item's dispatch first, during interpretion.

[Jacek Caban]

Hi Gabriel,


On 11/03/2020 14:06, Gabriel Ivăncescu wrote:
> @@ -2995,6 +3008,8 @@ HRESULT exec_source(script_ctx_t *ctx, DWORD flags, bytecode_t *bytecode, functi
>               hres = create_named_item_script_obj(ctx, bytecode->named_item);
>               if(FAILED(hres)) return hres;
>           }
> +        if(variable_obj == ctx->global)
> +            variable_obj = bytecode->named_item->script_obj;

This could be a separated patch. If in this case caller can't handle 
variable_obj in many cases, maybe it shouldn't handle it at all. It 
seems to me that we could get rid of that argument. exec_source has all 
information needed to handle it by itself.


Thanks,

Jacek