Re: [PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.

[Erich E. Hoover]

Thanks Piotr!

I'm happy to change that, I was just using the fprintf tests as a
template.  Does the attached look better to you?

Best,
Erich

On Thu, Oct 17, 2019 at 5:23 AM Piotr Caban <piotr.caban(a)gmail.com> wrote:
> Hi Erich,
>
> The implementation part of the patch doesn't look right. I think that it
> should be fixed by %s format reporting error when there's no characters
> to read.
>
> I'm attaching a diff (generated on top of your patch) that shows the
> problems.
>
> Also please use only tests on strings (sscanf) or handle file creation
> failure.
>
> Thanks,
> Piotr