Re: [PATCH v5 3/3] winegstreamer: Implement IMFMediaStream::GetStreamDescriptor.

[Zebediah Figura]

On 9/25/20 9:49 AM, Derek Lesho wrote:
> @@ -775,6 +812,19 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_
>      }
>
> WaitForSingleObject(object->no_more_pads_event, INFINITE);
> +    for (i = 0; i < object->stream_count; i++)
> +    {
> +        GstSample *preroll;
> +        g_signal_emit_by_name(object->streams[i]->appsink, "pull-preroll", &preroll);
> +        hr = E_FAIL;

This statement is superfluous now.
> +        if (FAILED(hr = media_stream_init_desc(object->streams[i])))
> +        {
> +            ERR("Failed to finish initialization of media stream %p, hr %x.\n", object->streams[i], hr);
> +            IMFMediaStream_Release(&object->streams[i]->IMFMediaStream_iface);
> +            goto fail;
> +        }
> +        gst_sample_unref(preroll);
> +    }
>
> object->state = SOURCE_STOPPED;

With that addressed, I think I have no further concerns regarding this
patch series; I'll leave it to Nikolay to undo all of my review ;-)