Re: [PATCH vkd3d 3/5] vkd3d-shader/hlsl: Handle samplers in write_sm1_uniform().

[Zebediah Figura]

On 11/9/21 10:12 AM, Giovanni Mascellani wrote:
> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
> --
> I don't really know much about SM1, so I wouldn't swear the patch is
> correct. But it looks sensible and it doesn't appear to be breaking
> totally unrelated things.
>
> Only thing I would change is to leave "put_u32(buffer,
> var->data_type->reg_size / 4)" out of the conditional, since I think I
> remember that textures and samplers have register size 4. But it's not a
> big deal.

I believe they currently have reg_size 0. There's not a meaningful 
register size for them anyway.