Re: [PATCH 1/2] strmbase: Leave critical section when waiting for the renderer state change.

[Zebediah Figura (she/her)]

On 5/28/21 2:05 AM, Anton Baskanov wrote:
> Sometimes streaming thread gets stuck in IPin::EndOfStream trying to
> acquire the filter critical section for more than 1 second, causing
> intermittent test failures.
>
> Signed-off-by: Anton Baskanov <baskanov(a)gmail.com>

Sorry for the late review.

The streaming thread shouldn't be doing that; that's basically one of 
the underdocumented rules of quartz, you can't access the filter CS from 
the streaming thread.

I'm presuming this is the part where it tries to check "pin->flushing"; 
this is basically wrong as-is, but it needs some extra work to solve, 
including (ideally) wineqtdecoder either being restructured or going 
away entirely.