Re: msi: Uninitialized variable fix (Coverity)

[Andrew Talbot]

James Hawkins wrote:
> On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot
> <andrew.talbot(a)talbotville.com> wrote:
> > Fix for Coverity error CID: 762.
> >
> > [...]
> > -    RegCloseKey(userdata);
> > +    if (userdata) RegCloseKey(userdata);
> >     return rc;
>
> Please don't add another NULL-before-free check.

Hi James,

Sorry, I don't understand what I have done wrong. RegCloseKey() will return ERROR_INVALID_HANDLE if called with hkey==NULL.

-- 
Andy.