Re: msi [1/6]: Add support for remote handles

[Alexandre Julliard]

"James Hawkins" <truiken(a)gmail.com> writes:
> @@ -215,18 +282,28 @@ UINT WINAPI MsiCloseHandle(MSIHANDLE han
>
> EnterCriticalSection( &MSI_handle_cs );
>
> -    info = msihandle2msiinfo(handle, 0);
> -    if( !info )
> -        goto out;
> -
> -    if( info->magic != MSIHANDLE_MAGIC )
> +    unk = msi_get_remote( handle );
> +    if (unk)
> +        IUnknown_Release( unk );
> +    else
>      {

It seems to me you are leaking the object here, the handle entry holds
a ref to it too.

-- 
Alexandre Julliard
julliard(a)winehq.org