On Tue, 27 Feb 2018, Zebediah Figura wrote:
Now that we have support for custom dlls in e.g. dlls/msi/tests/custom.c. [...] add_test_line("failed", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "failure"); [...] add_test_line("todo", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "todo");
Note that with these two chunks check_unit() would be unused so it should be removed (and maybe some infrastructure for it too). But then I'd prefer to preserve the check somehow. However I don't see a case where this patch is needed so far. Maybe I missed something? -- Francois Gouget <fgouget(a)codeweavers.com>