Re: [PATCH] avrt: Add AvQuerySystemResponsiveness stub.

[Huw Davies]

On Wed, Aug 16, 2017 at 08:39:32PM +0800, Dmitry Timoshkov wrote:
> Huw Davies <huw(a)codeweavers.com> wrote:
> > > +BOOL WINAPI AvQuerySystemResponsiveness(HANDLE AvrtHandle, PULONG SystemResponsivenessValue)
> > > +{
> > > +    FIXME("(%p, %p): stub\n", AvrtHandle, SystemResponsivenessValue);
> > > +    return TRUE;
> > > +}
> > > +
> >
> > If you're going to return TRUE, you need to initialize
> > *SystemResponsivenessValue to something meaningful.
> >
> > While you're at it, we generally prefer 'ULONG *' to 'PULONG',
>
> I'd guess that public APIs should follow the PSDK declarations, and
> where PSDK has PULONG an appropriate Wine header should have ULONG
> as well.

This isn't a header, it's the implementation.

Even in a header it would be better to be more typographically
different from the PSDK.

Huw.