Re: [PATCH vkd3d 2/8] vkd3d-shader/glsl: Implement vkd3d_glsl_generator_generate().

[Henri Verbeet]

On Wed, 18 Aug 2021 at 06:20, Atharva Nimbalkar <atharvakn(a)gmail.com> wrote:
> +static void VKD3D_PRINTF_FUNC(3, 4) vkd3d_glsl_compiler_error(
> +        struct vkd3d_glsl_generator *generator,
> +        enum vkd3d_shader_error error, const char *fmt, ...)
> +{
> +    va_list args;
> +
> +    va_start(args, fmt);
> +    vkd3d_shader_error(generator->message_context, &generator->location, error, fmt, args);
> +    va_end(args);
> +    generator->failed = true;
> +    return;
> +}
> +
> That doesn't quite do the right thing. You should use
> vkd3d_shader_verror() instead of vkd3d_shader_error() here, so that
> "args" is interpreted as an argument list instead of matching against
> the first argument in the format string.