Re: [PATCH vkd3d 3/7] vkd3d: Use the resource's stored format in d3d12_command_list_CopyTextureRegion().

[Henri Verbeet]

On Tue, 18 Jan 2022 at 06:08, Conor McCarthy <cmccarthy(a)codeweavers.com> wrote:
> @@ -3498,12 +3498,7 @@ static void STDMETHODCALLTYPE d3d12_command_list_CopyTextureRegion(ID3D12Graphic
>          assert(d3d12_resource_is_texture(dst_resource));
>          assert(d3d12_resource_is_buffer(src_resource));
>
> -        if (!(src_format = vkd3d_format_from_d3d12_resource_desc(list->device,
> -                &dst_resource->desc, src->u.PlacedFootprint.Footprint.Format)))
> -        {
> -            WARN("Invalid format %#x.\n", src->u.PlacedFootprint.Footprint.Format);
> -            return;
> -        }
> +        src_format = dst_resource->format;

Is that right? This would previously use
"src->u.PlacedFootprint.Footprint.Format" if non-zero.