Re: [PATCH 5/5] windows.media.speech: Store speech commands in listconstraint.

[Rémi Bernon]

On 3/28/22 21:58, Rémi Bernon wrote:
> On 3/28/22 18:15, Bernhard Kölbl wrote:
> > +
> > +    impl = impl_from_IVector_HSTRING(*out);
> > +    impl->size = 0;
> > +    impl->capacity = capacity;
> > +    impl->elements = realloc(impl->elements, impl->capacity * 
> > sizeof(*impl->elements));
> > +
>
> You're not handling the allocation failure here, I think you should.

About allocation failures, I've signed off on the previous patches 
already, but I see now that WindowsDuplicateString can eventually make a 
copy and fail.

Although unlikely it should probably be handled too.
-- 
Rémi Bernon <rbernon(a)codeweavers.com>