Re: [PATCH] mshtml: Implement HTMLStyleSheetRulesCollection::item.

[Jacek Caban]

Hi Dmitry,

The patch looks mostly good.

On 5/6/19 6:57 AM, Dmitry Timoshkov wrote:
> @@ -169,8 +339,22 @@ static HRESULT WINAPI HTMLStyleSheetRulesCollection_item(IHTMLStyleSheetRulesCol
>           LONG index, IHTMLStyleSheetRule **ppHTMLStyleSheetRule)
>   {
>       HTMLStyleSheetRulesCollection *This = impl_from_IHTMLStyleSheetRulesCollection(iface);
> -    FIXME("(%p)->(%d %p)\n", This, index, ppHTMLStyleSheetRule);
> -    return E_NOTIMPL;
> +    nsIDOMCSSRule *nsstylesheetrule;
> +    nsresult nsres;
> +
> +    TRACE("(%p)->(%d %p)\n", This, index, ppHTMLStyleSheetRule);
> +
> +    nsres = nsIDOMCSSRuleList_Item(This->nslist, index, &nsstylesheetrule);
> +    if (NS_FAILED(nsres) || !nsstylesheetrule)
> +    {
> +        WARN("Item failed: %08x\n", nsres);
> +        /* The function returns S_OK even if the element is not found */
> +        *ppHTMLStyleSheetRule = NULL;

This test does not confirm that:

https://testbot.winehq.org/JobDetails.pl?Key=51932


Thanks,

Jacek