Re: [PATCH 1/2] setupapi/tests: Add error tests for SetupDiDestroyDeviceInfoList.

[Dmitry Timoshkov]

Jeff Smith <whydoubt(a)gmail.com> wrote:
> +    SetLastError(0xcafef00d);

Please use a commonly accepted value of 0xdeadbeef.
> +    ret = SetupDiDestroyDeviceInfoList(set);
> +    ok(ret, "Failed to destroy device list, error %#x.\n", GetLastError());
> +    todo_wine ok(!ret || !GetLastError(), "Got unexpected error %#x.\n", GetLastError());

These two ok() calls contradict each other (here and in other places).
ok() should accept either ret or !ret, last error should be tested
separately.

-- 
Dmitry.